Skip to content

Liquid enhancements2#2418

Open
lmckenzi wants to merge 16 commits into
masterfrom
LiquidEnhancements2
Open

Liquid enhancements2#2418
lmckenzi wants to merge 16 commits into
masterfrom
LiquidEnhancements2

Conversation

@lmckenzi
Copy link
Copy Markdown
Collaborator

Enhanced the Liquid engine to support the full Liquid spec (with the exception of the Where and Map filters). See also FHIR/fhir-test-cases#265 which has complete tests for all of the new functionality (aligned with the tests in the Liquid spec).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.82%. Comparing base (fb7830f) to head (3c07d81).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2418      +/-   ##
============================================
+ Coverage     13.80%   13.82%   +0.02%     
- Complexity    38654    38761     +107     
============================================
  Files          2541     2546       +5     
  Lines        731686   732369     +683     
  Branches     213340   213412      +72     
============================================
+ Hits         100978   101237     +259     
- Misses       596881   597300     +419     
- Partials      33827    33832       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@dotasek dotasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See notes.

All tests pass at this point (when run with the appropriate test branch), and the new code is covered with the exception of the new markdown implementation. Is that intended to also be under test?

Comment thread org.hl7.fhir.r5/src/main/java/org/hl7/fhir/r5/liquid/LiquidEngine.java Outdated
Copy link
Copy Markdown
Collaborator

@dotasek dotasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending @lmckenzi 's review of the new exceptions I added.

@lmckenzi
Copy link
Copy Markdown
Collaborator Author

lmckenzi commented Jun 3, 2026

I'm fine with those changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants